Introduce TemplateDataWithLibrary and TemplateDataWithContainer. #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two interfaces are necessary in order to render certain TemplateData
subtypes into _sidebar_for_library.html and _sidebar_for_container.html,
respectively.
Since _sidebar_for_library.html references `{{#library}}`, the static type
rendered into this template needs a `library` getter. Same for the other
sidebar.
Additionally, _sidebar_for_container.html accesses `hasPublicConstructors` and
`publicConstructorsSorted` on Container, so that type needs those getters.
jcollins-g
approved these changes
Feb 22, 2021
|
Hahaha yes. Alas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two interfaces are necessary in order to render certain TemplateData
subtypes into _sidebar_for_library.html and _sidebar_for_container.html,
respectively.
Since _sidebar_for_library.html references
{{#library}}, the static typerendered into this template needs a
librarygetter. Same for the othersidebar.
Additionally, _sidebar_for_container.html accesses
hasPublicConstructorsandpublicConstructorsSortedon Container, so that type needs those getters.