Remove URI library #2471
Merged
Remove URI library #2471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can update this after #2470 is merged or the other way around as well. |
jcollins-g
approved these changes
Jan 5, 2021
parlough
force-pushed
the
feature/remove-uri
branch
from
64ce582 to
a1254d5
Compare
|
@jcollins-g This has been rebased on master and should be good to go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
URI.jslibrary as modern browsers have built-in handling for getting query parameters and this library is 9.4 KB (28.4 uncompressed) for just one use.While IE11 doesn't support this API, search functionality didn't work there in the first place nor did some other functionality, and this has feature detection, so shouldn't cause any errors if used in IE.
Breaking change: This removes the
URI.jslibrary from being included along with generated HTML documentation. While unlikely, downstream users may be using this.