Mustachio: add SimpleRenderer and demote many classes from using full renderers #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review again; concept of "visible" to mustache has changed. |
jcollins-g
approved these changes
Dec 16, 2020
| /// A set of types which are "visible" to Mustache. Mustache rendering has | ||
| /// access to all of a type's public getters if it is visible to Mustache. | ||
| /// | ||
| /// Note that all subtypes and supertypes of a "visible" type are also visible |
srawlins
force-pushed
the
mustachio-a
branch
from
facfe67 to
527df4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderers were getting unwieldy and were only going to grow more. This introduces a SimpleRenderer for most classes.
If a class is not specified with
@Renderer, we can also annotate a class with @visibleToMustache. Otherwise, it will use a SimpleRenderer. For example, if String does not use a full renderer, then we cannot access it's fields (String.length, etc).This change highlighted some issues with InterfaceType vs ClassElement and we've mostly changed to us Element, and I think the code is much cleaner.
This deletes almost 4000 lines from templates.renderers.dart, haha.