Add a link to the null safety feature indicator #2455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
changed the title
jcollins-g
approved these changes
Dec 16, 2020
|
overriding failure and merging anyway -- this is the old sdk-analyzer bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to click the "Null safety" feature and open the documentation about null safety. I think this is especially useful currently as not all users are familiar with the new functionality yet.
This implements the change by adding an optional URL for the feature which will, if present, cause the HTML renderer to use an anchor tag instead of a span and the Markdown renderer to use a normal Markdown link.
I added a special border style on hover to match other similar buttons such as the source code button.
Default:
On hover(if has an associated URL):
