Use = to document default values for named parameters - Fixes #2087 #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
force-pushed
the
fix/default-parameter-formatting
branch
from
2b54cd9 to
efd7295
Compare
|
Thanks for the contribution! It looks like some tests need to be updated, but otherwise this is looking good. |
|
@jcollins-g Thanks for pointing that out, should be good to go now! |
jcollins-g
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is suggested in Effective Dart to use = for assigning default values for optional named parameters to be consistent with positional ones as well, so this special handling can be removed.
Fixes #2087