Skip to content

Mustachio: Implement Property.isNullValue, renderValue; section rendering; lots of tests #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Mustachio: Implement Property.isNullValue, renderValue; section rendering; lots of tests #2448

merged 1 commit into from
Dec 7, 2020

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Dec 4, 2020

  • Add Property.isNullValue and renderValue for non-bool, non-Iterable fields
  • Implement Section rendering, which uses the above two functions
  • Test it all
  • Testing reveals a parsing bug with a value tag immediately followed by a section end tag.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Dec 4, 2020
@srawlins srawlins requested a review from jcollins-g December 5, 2020 03:16
@jcollins-g jcollins-g mentioned this pull request Dec 7, 2020
Merged
@jcollins-g jcollins-g merged commit d320b5e into dart-lang:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @jcollins-g