Mustachio: Add getProperty(), and end-to-end Renderer test #2442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test This includes some unorthodox tests: I've added a package in `testing/mustachio`, complete with a pubspec.yaml and a build.yaml. These are required in order to test the runtime behavior of generated code; in order to make assertions on the generated code (not its String content, but its runtime properties), it must be generated with public classes (the default is private). In order to pass a configuration to the Builder, I need a build.yaml separate from dartdoc's. In order to import `testing/mustachio/lib/foo.renderers.dart`, and resolve that library's reference to `package:testing_mustachio/foo.dart`, I need to add `testing_mustachio` to `dev_dependencies`. In order to reference the builders from the testing package, the builder code needed to move from `tool/mustachio/` to `lib/src/mustachio/`. The generated code now always references the library that generated it, on the assumption that it needs types from that file. This is not necessarily correct, but is a decent approximation until we start using code_builder. RendererBase now needs to know about the renderer of the parent context type, so it gets a new field. Property and each renderer's propertyMap gets corrected code; the runtime tests revealed some runtime type bugs.
|
@jcollins-g what do you think about the try-publish failure? Moving the builder to lib/ would necessitate (?) that |
|
@jcollins-g OK I think I've got this working; I've added a second build target in build.yaml which builds testing code. build_runner refused to generate any files in |
jcollins-g
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code now always references the library that generated it, on the
assumption that it needs types from that file. This is not necessarily correct,
but is a decent approximation until we start using code_builder.
RendererBase now needs to know about the renderer of the parent context type,
so it gets a new field.
Property and each renderer's propertyMap gets corrected code; the runtime tests
revealed some runtime type bugs.