Add real mustachio annotation, and check in in-progress renderers. #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add mustachio to build.yaml * Add a class Renderer, meant to be used as an annotation * Add one @Renderer annotation to templates.dart * Add the generated templates.renderers.dart file. While in-progress, this library is valid Dart, and passes static analysis. Checking it in ensures that it will continue to be valid Dart, and pass static analysis. * Remove the abstract `getFields` method; the generated code doesn't implement it yet; this was checked in prematurely. * Remove the templateUri field from the mock Renderer class in the tests; this field won't be needed; template URIs are provided at runtime.
jcollins-g
reviewed
Nov 17, 2020
jcollins-g
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Rendererannotation to templates.dartlibrary is valid Dart, and passes static analysis. Checking it in ensures
that it will continue to be valid Dart, and pass static analysis.
getFieldsmethod; the generated code doesn't implementit yet; this was checked in prematurely.
templateUrifield from the mock Renderer class in the tests; thisfield won't be needed; template URIs are provided at runtime.