Skip to content

Enable NNBD experiment for dartdoc #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Enable NNBD experiment for dartdoc #2384

merged 1 commit into from
Oct 13, 2020

Conversation

jcollins-g
Copy link
Contributor

This will document any NNBD-enabled packages with "null safety" by default, rather than pretending they aren't null safe.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Oct 12, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 92.062% when pulling 4d8d076 on nnbd-experiment-on into 8f5f30e on master.

@srawlins
Copy link
Member

This will document any NNBD-enabled packages with "null safety" by default, rather than pretending they aren't null safe.

Does it document any NNBD-not-enabled packages as "null safety" because it still requires opting in (via SDK constraint I guess)?

@jcollins-g
Copy link
Contributor Author

This will document any NNBD-enabled packages with "null safety" by default, rather than pretending they aren't null safe.

Does it document any NNBD-not-enabled packages as "null safety" because it still requires opting in (via SDK constraint I guess)?

I'm not sure I understand, but if you are asking if we force-override and try to parse a non-migrated package to be null safe, the answer is no. With or without the flag in dartdoc set, we always trust the analyzer to know whether a package is null safe. This only changes what dartdoc will generate for the output for null safe packages.

@jcollins-g jcollins-g merged commit afa4199 into master Oct 13, 2020
@jcollins-g jcollins-g deleted the nnbd-experiment-on branch October 13, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants