Typedef implements ModelFunctionTyped. #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The relationship is different from ModelFunctionTypedef which _extends_ ModelFunctionTyped because the typedef is the alias _which contains_ a function-typed element. Nevertheless, Typedef was always implementing (approximately) the interface defined by ModelFunctionTyped because both types are sent to the _callable template. Additionally one change is made to the ModelFunctionTyped interface such that Typedef perfectly implements ModelFunctionTyped. * **Breaking change**: Remove the `typeParameters` setter. The field is now final.
jcollins-g
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relationship is different from ModelFunctionTypedef which extends
ModelFunctionTyped because the typedef is the alias which contains a
function-typed element. Nevertheless, Typedef was always implementing
(approximately) the interface defined by ModelFunctionTyped because both types
are sent to the _callable template.
Additionally one change is made to the ModelFunctionTyped interface such that
Typedef perfectly implements ModelFunctionTyped.
typeParameterssetter. The field is now final.