Skip to content

Access TemplateRenderer from PackageGraph like other renderers #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2020
Merged

Access TemplateRenderer from PackageGraph like other renderers #2114

merged 3 commits into from
Jan 7, 2020

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Jan 7, 2020 •
edited
Loading

Fix the one renderer was not being accessed through the RendererFactory.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 7, 2020
jcollins-g
jcollins-g approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, cleans things up well.

@jdkoren jdkoren merged commit c7f7ec5 into dart-lang:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdkoren @jcollins-g @googlebot