Add 'late' as a feature for final variables #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Nov 14, 2019
lib/src/model/field.dart
Outdated
| @@ -92,6 +92,12 @@ class Field extends ModelElement | |||
| return field.isFinal; | |||
| } | |||
|
|
|||
| @override | |||
| bool get isLate { | |||
| if (isFinal) return field.isLate; | |||
There was a problem hiding this comment.
Consider return isFinal && field.isLate;
There was a problem hiding this comment.
changed to bool get isLate => isFinal && field.isLate;
scheglov
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dartdoc will now add this to the feature list and display it as part of the API, where appropriate. @scheglov's comment in #2069 made me reconsider the value of showing late, as previously all final variables were always initialized.
Also added tests for isFinal in the base case, this was barely touched previously.
Screenshots of the new feature flag: