Rank parent class method higher than its overrides in search suggestions #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do that by saving `overriddenDepth` to index.json (which is just how many overridden elements in the inheritance chain that element has), and then reducing weight of elements in the suggestions according to `overriddenDepth`. Also, fixed `grind update-test-package-docs`, it didn't know where to find examples for `@examples` directives. Fixes dart-lang#896
astashov
force-pushed
the
rank-base-classes-higher-in-suggestions
branch
from
6241b0b to
7fb34c8
Compare
|
Thanks! Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do that by saving
overriddenDepthto index.json (which is justhow many overridden elements in the inheritance chain that element has),
and then reducing weight of elements in the suggestions according to
overriddenDepth.Also, fixed
grind update-test-package-docs, it didn't know where tofind examples for
@examplesdirectives.Fixes #896