Remove support for fixes and --fix.
#1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tools that come with the Dart SDK provide two ways to apply automated changes to code: `dart format --fix` and `dart fix`. The former is older and used to be faster. But it can only apply a few fixes and hasn't been maintained in many years. The `dart fix` command is actively maintained, can apply all of the fixes that `dart format --fix` could apply and many many more. In order to avoid duplicate engineering effort, we decided to consolidate on `dart fix` as the one way to make automated changes that go beyond the simple formatting and style changes that `dart format` applies. The ability to apply fixes is also removed from the `DartFormatter()` library API.
24 tasks
kallentu
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tools that come with the Dart SDK provide two ways to apply automated changes to code:
dart format --fixanddart fix. The former is older and used to be faster. But it can only apply a few fixes and hasn't been maintained in many years. Thedart fixcommand is actively maintained, can apply all of the fixes thatdart format --fixcould apply and many many more.In order to avoid duplicate engineering effort, we decided to consolidate on
dart fixas the one way to make automated changes that go beyond the simple formatting and style changes thatdart formatapplies.The ability to apply fixes is also removed from the
DartFormatter()library API.cc @mit-mit, @keertip