[Formatting issue] Weird linebreaks in loops

[lishaduck]

What input code did you provide to the formatter?

Column(
  children: [
    for (final CommentEntity(:comment, :timestamp, :authorName) in value.comments) ...[
      CircleAvatar(
        backgroundImage: MemoryImage(value.avatar),
      ),
      Text(authorName),
      Timeago(
        date: timestamp,
        builder: (context, value) => Text(value),
      ),
      Text(comment),
    ],
  ],
),

What output did the formatter produce?

Column(
  children: [
    for (final CommentEntity(
          :comment,
          :timestamp,
          :authorName,
        )
        in value.comments) ...[
      CircleAvatar(
        backgroundImage: MemoryImage(value.avatar),
      ),
      Text(authorName),
      Timeago(
        date: timestamp,
        builder: (context, value) => Text(value),
      ),
      Text(comment),
    ],
  ],
),

What output did you expect or want the formatter to produce?

I honestly don't know, but this is hard to read.

Maybe this?

Column(
  children: [
    for (
      final CommentEntity(
          :comment,
          :timestamp,
          :authorName,
      ) in value.comments
    ) ...[
      CircleAvatar(
        backgroundImage: MemoryImage(value.avatar),
      ),
      Text(authorName),
      Timeago(
        date: timestamp,
        builder: (context, value) => Text(value),
      ),
      Text(comment),
    ],
  ],
),

Anything else we should know?

Thanks!

^ You're welcome!

Uhh, this is inside of a deeply nested Flutter structure, that's why it's linebreaking so soon.

[munificent]

Line breaks inside the header of a for loop are hard. I agree that the current formatting isn't beautiful. But I spent a lot of time looking at hand-formatted Flutter code when designing the new style and that seems to most closely reflect what most human authors were doing.

Sometimes there's only so much the formatter can do.