Skip to content

Reland unit test UI against local backend. #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented May 7, 2025

  1. Reverts Revert "Unit test against local backend." #3280 to reland Unit test against local backend. #3278, that failed with Compilation fails due to CORS error #3279
  2. Test covers populateVersions that maybe caused the issue.
  3. Removes probes from UI testing, as we plan to create them differently in pkgs/dartpad_services

Fixes #3284

Copy link

github-actions bot commented May 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

@polina-c polina-c changed the title Reland unit test against local backend. [Draft] Reland unit test against local backend. May 8, 2025
@polina-c polina-c changed the title [Draft] Reland unit test against local backend. Reland unit test against local backend. May 9, 2025
@polina-c polina-c changed the title Reland unit test against local backend. Reland unit test UI against local backend. May 9, 2025
@polina-c polina-c marked this pull request as ready for review May 9, 2025 19:10
@polina-c polina-c requested a review from johnpryan May 9, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run UI unit tests against local backend.
1 participant