-
Notifications
You must be signed in to change notification settings - Fork 34
Run fixnum tests with dart2wasm #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. This check can be disabled by tagging the PR with |
devoncarew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, through we should get the CI passing before landing.
It looks like this passes on dev but not on dart 3.1. That's an older SDK - if it fixes the CI, we can just bump to requiring a newer SDK (up to and including the current stable, 3.9).
Fixes package:test running dart2wasm.
|
@devoncarew I tested latest releases starting with 3.1:
3.4.4 was released on 13 Jun 2024. Based on this, I updated the min. SDK version to 3.4.4. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/1547a83..bc90433): bc90433 2025-09-04 Greg Spencer Add pub add format guidance (dart-lang/ai#278) 845c126 2025-09-04 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/ai#277) 5568958 2025-09-04 Jacob MacDonald add a GEMINI.md file (dart-lang/ai#279) core (https://github.com/dart-lang/core/compare/5c3e2c3..a4dc873): a4dc8738 2025-09-09 Ömer Sinan Ağacan Implement `Int64` as a wrapper for `int` when targeting native and Wasm (dart-lang/core#905) 1aa58ef5 2025-09-08 Devon Carew [fixnum] update the min. required dart sdk (dart-lang/core#907) 60f2b5d3 2025-09-08 Ömer Sinan Ağacan Run fixnum tests with dart2wasm (dart-lang/core#906) dartdoc (https://github.com/dart-lang/dartdoc/compare/53222e2..efff7c1): efff7c1f 2025-09-08 Sarah Zakarias Remove runtime_renderers.dart (dart-lang/dartdoc#4101) 4e2daf57 2025-09-05 Sarah Zakarias Rename LanguageFeature and remove FeatureSet mixin (dart-lang/dartdoc#4099) ecc48d00 2025-09-02 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/dartdoc#4098) protobuf (https://github.com/dart-lang/protobuf/compare/0a13935..971bcae): 971bcae 2025-09-08 Ömer Sinan Ağacan Use a map to cache the `valueOf` functions for enums (google/protobuf.dart#1047) 8750ed7 2025-09-05 Ömer Sinan Ağacan Sync internal Kythe support improvements (google/protobuf.dart#1048) web (https://github.com/dart-lang/web/compare/a152054..e2daa3a): e2daa3a 2025-09-04 Nikechukwu [interop] Add support for Intersection types (dart-lang/web#451) webdev (https://github.com/dart-lang/webdev/compare/52ad019..23aefeb): 23aefebe 2025-09-05 jensjoha Fix CI flake in dwds/test/hot_restart_breakpoints_test.dart (dart-lang/webdev#2685) Change-Id: I36cfbcdd884e8e0e38e24a9c7f3bcfcc15fdd9ff Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449000 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
No description provided.