#3315. Move name conflicts tests for constructors to Primary-constructors
#3397
Conversation
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, except that a bunch of deleted files seem to tests that are still valid (in some cases, all of them, in other cases just some). Do we drop some coverage by deleting those tests, or are those tests already present in some other libraries?
| print(M5); | ||
| print(M6); | ||
| print(M7); | ||
| } |
There was a problem hiding this comment.
So M1, M3, M4, M7 are still being tested, just in some other file?
| print(M5); | ||
| print(M6); | ||
| print(M7); | ||
| } |
There was a problem hiding this comment.
Same consideration, M1, M3 look like they're still valid.
| print(C3); | ||
| print(C4); | ||
| print(C5); | ||
| } |
There was a problem hiding this comment.
All OK, also with the newest changes? Covered somewhere else?
| main() { | ||
| print(E1); | ||
| print(E2); | ||
| } |
| main() { | ||
| Expect.equals(1, ET1(1).v); | ||
| Expect.equals(2, ET2(2).v); | ||
| } |
| main() { | ||
| Expect.equals(1, ET1(1).v); | ||
| Expect.equals(2, ET2(2).v); | ||
| } |
| enum const E2.someName(final int v) { | ||
| e0(2); | ||
|
|
||
| const factory E2(int v) => E2.e0; |
There was a problem hiding this comment.
This one can't be const because it has a body. Perhaps it was intended to be redirecting?
| main() { | ||
| Expect.equals(1, E1.e0.v); | ||
| Expect.equals(2, E2.e0.v); | ||
| } |
| /// the body. | ||
| /// | ||
| /// @description Check that it is a compile-time error if the name of the | ||
| /// declaring constructor is the same as the name of some constructor declared |
There was a problem hiding this comment.
'primary' rather than 'declaring'.
| } | ||
|
|
||
| extension type ET4 { | ||
| this.someName(final int v); |
There was a problem hiding this comment.
So ET4 doesn't make sense any more.
2 participants
Declaring-constructors/static_processing_A02_t*.dartandDeclaring-constructors/static_processing_A03_t*.dartdeleted. They updated copies were added toPrimary-constructorsearlier but these files were not deleted.