#3180. Add more js_interop tests
#3232
Conversation
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion An opaque reference to a Dart object that can be passed to |
There was a problem hiding this comment.
nit: Do we need to copy the documentation here and elsewhere? If it ever changes this might become stale.
There was a problem hiding this comment.
This is our usual approach. While the documentation may occasionally become outdated, it can also indicate that the corresponding test needs to be revised. Let's keep it for now.
| } | ||
| '''); | ||
| if (isWasm) { | ||
| ExternalDartReference<C> jsC = getCfromJS(); |
There was a problem hiding this comment.
You can't really test it because it traps (I think), but worth leaving a comment that if you did toDartObject, this would error on dart2wasm.
There was a problem hiding this comment.
The comment added.
| } | ||
|
|
||
| @JS() | ||
| external ExternalDartReference<C> getCfromJS(); |
There was a problem hiding this comment.
We already have tests for this in the SDK, but you could try ExternalDartReference<C?> and ExternalDartReference<C>? variants.
There was a problem hiding this comment.
Nullable variants added.
|
|
||
| /// @assertion A JavaScript `BigInt` | ||
| /// | ||
| /// @description Check that `JSBigInt` can store big integer values (more that |
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion An opaque reference to a Dart object that can be passed to |
There was a problem hiding this comment.
This is our usual approach. While the documentation may occasionally become outdated, it can also indicate that the corresponding test needs to be revised. Let's keep it for now.
| } | ||
| '''); | ||
| if (isWasm) { | ||
| ExternalDartReference<C> jsC = getCfromJS(); |
There was a problem hiding this comment.
The comment added.
|
|
||
| /// @assertion A JavaScript `BigInt` | ||
| /// | ||
| /// @description Check that `JSBigInt` can store big integer values (more that |
| } | ||
|
|
||
| @JS() | ||
| external ExternalDartReference<C> getCfromJS(); |
There was a problem hiding this comment.
Nullable variants added.
No description provided.