Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to d04448ab450608d05460ee467db2d5e4fc245295 #2310

Closed
sgrekhov opened this issue Oct 13, 2023 · 0 comments
Closed

Failures on [co19] Roll co19 to d04448ab450608d05460ee467db2d5e4fc245295 #2310

sgrekhov opened this issue Oct 13, 2023 · 0 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@sgrekhov
Copy link
Contributor

There are new test failures on [co19] Roll co19 to d04448ab450608d05460ee467db2d5e4fc245295.

The tests

co19/Language/Classes/Instance_Methods/Method_noSuchMethod/definition_A03_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Private-fields-promotion/not_promotable_A02_t06 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Private-fields-promotion/promotion_A04_t08 CompileTimeError (expected Pass)
co19/LanguageFeatures/Private-fields-promotion/promotion_A04_t09 CompileTimeError (expected Pass)
co19/LanguageFeatures/Private-fields-promotion/promotion_A04_t10 CompileTimeError (expected Pass)
co19/LibTest/io/Link/create_A04_t10 RuntimeError (expected Pass)
co19/LibTest/io/Link/create_A04_t14 RuntimeError (expected Pass)

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-linux-chrome-unsound
dart2js-hostasserts-linux-d8
dart2js-linux-chrome
dart2wasm-linux-chrome
dart2wasm-linux-d8
ddc-linux-chrome
ddc-linux-chrome-unsound
vm-mac-debug-arm64
vm-mac-release-arm64
@sgrekhov sgrekhov self-assigned this Oct 13, 2023
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Oct 13, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 13, 2023
@sgrekhov
Fixes dart-lang#2310. Fix new roll failures
4e93f72
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 15, 2023
@sgrekhov
[co19] Roll co19 to 9d347fdf209cc343ca7fdf94a40deea88fa28896
bb28597 
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2310. Fix new roll failures (dart-lang/co19#2311)
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2306. Fix promoted instance type in not_promotable_A01_t04.dart (dart-lang/co19#2309)
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2307. Don't expect private fields promotion on static fields (dart-lang/co19#2308)
2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` tests according to the documentation (dart-lang/co19#2299)
2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 3 (dart-lang/co19#2294)
2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 4 (dynamic semantics) (dart-lang/co19#2296)
2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` according to the documentation. Part 2 (dart-lang/co19#2301)
2023-10-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2268. Fix LibTest/io/WebSocket/closeCode_A01_t02.dart to be not racy (dart-lang/co19#2302)
2023-10-09 sgrekhov22@gmail.com dart-lang/co19#1400. Add more tests for private fields promotion of extension types (dart-lang/co19#2300)

Change-Id: Ib34f392c8a2a0aaab8b7b0cb028f918ab2a3249f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330460
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov