Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Variables and Local Variable declaration according to spec #2145

Open
sgrekhov opened this issue Jul 20, 2023 · 1 comment
Open

Update Variables and Local Variable declaration according to spec #2145

sgrekhov opened this issue Jul 20, 2023 · 1 comment
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

Variables and Local Variable declaration sections of the specification were updated. See dart-lang/language@af27cfb. Need to update co19 tests accordingly
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Jul 20, 2023
@sgrekhov sgrekhov self-assigned this Jul 20, 2023
@eernstg
Copy link
Member

eernstg commented Jul 20, 2023

Right, these updates are quite substantial. The changes are the null safety related, so there should not be anything new for tests that are already targeting the language at a version where null safety has been introduced.

However, it would certainly be valuable to get an extra pair of eyes on the specification and the actual tool behavior, such that we can detect ways in which they disagree, if any. ;-)

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 21, 2023
@sgrekhov
dart-lang#2145. Add more tests for Variable
e9120fd
eernstg pushed a commit that referenced this issue Jul 26, 2023
@sgrekhov
#2145. Add more tests for Variable (#2146)
a4d7265 
Add more tests for variables. Note that Language/Classes/Instance_Variables/constant_t01.dart, Language/Variables/covariant_t01.dart, Language/Variables/static_variable_t02.dart have syntax errors intentionally.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 31, 2023
@sgrekhov
[co19] Roll co19 to 3f9d5d1f9ea353b61982236624809f930323dbf7
eeff47f 
2023-07-28 sgrekhov22@gmail.com dart-lang/co19#2142. Fix typo (dart-lang/co19#2155)
2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2149. Fix new errors due to changes with the constant evaluator (dart-lang/co19#2152)
2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2145. Add more tests for Variable (dart-lang/co19#2146)
2023-07-25 sgrekhov22@gmail.com dart-lang/co19#2142. Add syntax tests (dart-lang/co19#2148)

Change-Id: I6ee222b74fc092d93a1b76d35d89a008a97056be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316590
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 29, 2023
@sgrekhov
dart-lang#2145. Update variables tests according to the current spec.…
c703cd5 
… Part 2
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 29, 2023
@sgrekhov
dart-lang#2145. Update assertions and descriptions in the current Loc…
821d318 
…al variable declaration tests
eernstg pushed a commit that referenced this issue Aug 29, 2023
@sgrekhov
#2145. Update assertions and descriptions in the current Local variab…
526b298 
…le declaration tests (#2241)

Update assertions and descriptions in the current Local variable declaration tests.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 31, 2023
@sgrekhov
dart-lang#2145. Rename Local Variable declaration tests. Delete dupli…
645f959 
…cates
eernstg pushed a commit that referenced this issue Aug 31, 2023
@sgrekhov
#2145. Rename Local Variable declaration tests. Delete duplicates (#2252
604da63 
)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 1, 2023
@sgrekhov
dart-lang#2145. Add more local variable declaration tests
4beb74f
eernstg pushed a commit that referenced this issue Sep 1, 2023
@sgrekhov
#2145. Update variables tests according to the current spec. Part 2 (#…
ace9354 
…2240)

Update variable tests according to the current spec. Part 2
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 2, 2023
@sgrekhov
dart-lang#2145. Fix roll failure (LateInitializationError)
36e49c1
eernstg pushed a commit that referenced this issue Sep 4, 2023
@sgrekhov
#2145. Add more local variable declaration tests (#2254)
7bf88af 
Rename Local Variable declaration tests. Delete duplicates.
eernstg pushed a commit that referenced this issue Sep 4, 2023
@sgrekhov
#2145. Fix roll failure (LateInitializationError) (#2257)
ea1107d
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to ea1107d66f543f79ce865522ddd63718c8eb109e
4d9bfa2 
2023-09-04 sgrekhov22@gmail.com dart-lang/co19#2145. Fix roll failure (LateInitializationError) (dart-lang/co19#2257)
2023-09-04 sgrekhov22@gmail.com dart-lang/co19#2145. Add more local variable declaration tests (dart-lang/co19#2254)
2023-09-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (dart-lang/co19#2256)
2023-09-01 sgrekhov22@gmail.com dart-lang/co19#2213. Fix stack trace comparison (dart-lang/co19#2255)
2023-09-01 sgrekhov22@gmail.com dart-lang/co19#2145. Update variables tests according to the current spec. Part 2 (dart-lang/co19#2240)
2023-08-31 sgrekhov22@gmail.com dart-lang/co19#2242. Add LFCR line ending test (dart-lang/co19#2251)
2023-08-31 sgrekhov22@gmail.com dart-lang/co19#2145. Rename Local Variable declaration tests. Delete duplicates (dart-lang/co19#2252)
2023-08-30 sgrekhov22@gmail.com dart-lang/co19#2242. Add line endings tests (dart-lang/co19#2250)
2023-08-30 sgrekhov22@gmail.com Fixes dart-lang/co19#2245. Fix expectations in static_analysis_extension_types_A24_t02.dart (dart-lang/co19#2248)
2023-08-30 sgrekhov22@gmail.com dart-lang/co19#2242. Change CRLF line endings to LF (dart-lang/co19#2249)
2023-08-30 sgrekhov22@gmail.com Fixes dart-lang/co19#2244. Fix typo in dynamic_semantics_member_invocation_A01_t02.dart (dart-lang/co19#2247)
2023-08-30 sgrekhov22@gmail.com Fixes dart-lang/co19#2243. Remove duplicated constructors (dart-lang/co19#2246)
2023-08-29 sgrekhov22@gmail.com dart-lang/co19#2145. Update assertions and descriptions in the current Local variable declaration tests (dart-lang/co19#2241)
2023-08-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2235. Add missing operator tests (dart-lang/co19#2239)
2023-08-25 sgrekhov22@gmail.com dart-lang/co19#2119. Code format and description update in operator tests (dart-lang/co19#2238)

Change-Id: I5aeac05c1aa4cbaa0762ce4f23c1ee916d1006a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324040
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg