Skip to content

Print errors coming from the Isolate #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

Print errors coming from the Isolate #860

merged 1 commit into from
Jan 18, 2018

Conversation

natebosch
Copy link
Member

No description provided.

@natebosch natebosch requested a review from jakemac53 January 17, 2018 22:58
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Jan 17, 2018
@natebosch
Copy link
Member Author

Fixes #858

@natebosch
Copy link
Member Author

@nshahan - you'll want the same thing in your wrapper script

@natebosch natebosch requested a review from nshahan January 17, 2018 23:37
nshahan
nshahan approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the same change on the wrapper script. Thanks!

@natebosch natebosch merged commit 400b58d into master Jan 18, 2018
@natebosch natebosch deleted the forward-errors branch January 18, 2018 00:04
@natebosch natebosch mentioned this pull request Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natebosch @nshahan @googlebot