Add generate-build-script command #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #778 Wrapping entrypoints can use this to generate the build script and then run it using `Isolate.spawnUri` and avoid workaarounds like `--assume-tty`.
jakemac53
approved these changes
Jan 12, 2018
| // Use the actual command runner to parse the args and immediately print the | ||
| // usage information if there is no command provided or the help command was | ||
| // explicitly invoked. | ||
| var commandRunner = new BuildCommandRunner([]); | ||
| var commandRunner = new BuildCommandRunner([]) | ||
| ..addCommand(new _GenerateBuildScript()); |
There was a problem hiding this comment.
Any reason we shouldn't add this to the command runner generally?
There was a problem hiding this comment.
The other place we use this CommandRunner doesn't have the capability of performing this command.
nshahan
approved these changes
Jan 12, 2018
build_runner/bin/build_runner.dart
Outdated
|
|
||
| class _GenerateBuildScript extends Command { | ||
| @override | ||
| final description = 'Generate a script to run builds and print the file path'; |
There was a problem hiding this comment.
Nit: the script is generated no matter what, the command only prints the path and turns off logging. Maybe a note in the description about how this is only really useful for wrapper scripts.
jakemac53
approved these changes
Jan 12, 2018
|
Feel free to fix the analysis errors in a later pr as they are unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #778
Wrapping entrypoints can use this to generate the build script and then
run it using
Isolate.spawnUriand avoid workarounds like--assume-tty.