Fix library cycle graph update. #4004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
davidmorgan
force-pushed
the
update-library-cycle-graph
branch
from
118f1f3 to
23e0d98
Compare
davidmorgan
force-pushed
the
update-library-cycle-graph
branch
from
23e0d98 to
8aedd85
Compare
jensjoha
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3999.
The OOM was a distraction: it was because of the
$thisinthrow StateError('No value for phase $phase in $this.');, the library cycle graph is too big to flatten to a String for display. I removed those exception messages: better stack trace than a hang->OOM.The failure was because a partial build could cause information about deps of an asset to be discarded, leading "no value for phase" in the next build.