Skip to content

[build_web_compilers] Fix WebAssembly detection logic #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

[build_web_compilers] Fix WebAssembly detection logic #3931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_web_compilers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.1.3

- Fixed WebAssembly detection logic.

## 4.1.2

- Bump the min SDK to 3.7.0.
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/lib/src/web_entrypoint_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ function relativeURL(ref) {
dart2WasmResult?.supportExpression ??
"'WebAssembly' in self && "
'WebAssembly.validate(new Uint8Array('
'[0, 97, 115, 109, 1, 0, 0, 0, 1, 5, 1, 95, 1, 120, 0]));';
'[0, 97, 115, 109, 1, 0, 0, 0, 1, 5, 1, 95, 1, 120, 0]))';

loaderResult.writeln('''
if ($supportCheck) {
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_web_compilers
version: 4.1.2
version: 4.1.3
description: Builder implementations wrapping the dart2js and DDC compilers.
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers
resolution: workspace
Expand Down