Split out AssetTracker, create AssetGraphLoader and BuildPhases.
#3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
davidmorgan
force-pushed
the
reland-asset-graph-loader
branch
from
61a0c4a to
bd7c971
Compare
davidmorgan
force-pushed
the
reland-asset-graph-loader
branch
from
bd7c971 to
797e15e
Compare
davidmorgan
force-pushed
the
reland-asset-graph-loader
branch
from
797e15e to
af25d09
Compare
jensjoha
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
AssetTrackerout ofbuild_definition.dart.Add
BuildPhaseswrapping aList<BuildPhase>to hold validation and digest computation for the list.Move move load+verify of the graph from
build_definition.dartto newAssetGraphLoader. Move "delete graph outputs" from that toAssetGraph.