-
Notifications
You must be signed in to change notification settings - Fork 212
support 3.8 pre-release sdks #3795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
5bdfddd
to
2fe200c
Compare
Because of the way these packages are so tightly coupled to the SDK versions I'm not sure what counts as a breaking change in this context. If we were to want to build web compilers to pass different arguments in 3.8 when invoking DDC does that count as a breaking change? I'm also planning on removing the |
Yes, this is exactly the kind of change that would break build_web_compilers. I think in this case though, we only support sound null safety anyways I believe, so that should be OK (I don't see us passing that flag anywhere). |
Actually I just remembered we are guarding stable releases anyways because of the This will in effect declare support for 3.7 stable but that should be fine, I assume the branch is now cut and any breaking changes there already would be in (modulo cherry picks which shouldn't have changes like this). |
@nshahan I added you as a reviewer to confirm that we don't expect any breaking changes to the dev compiler command line in 3.8?
cc @jyameo