Skip to content

Update analyzer to 1.0.0. #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Feb 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
0c69f33
Add glob 2.0.0 to pubspecs
jcollins-g Feb 9, 2021
ae227e8
update built_value_generator
jcollins-g Feb 9, 2021
9fad1c4
Add nullsafe crypto to _test
jcollins-g Feb 9, 2021
fb7987f
Fix issues with glob via list_local_fs
jcollins-g Feb 9, 2021
cc4f6a7
Update js
jcollins-g Feb 10, 2021
04d4246
Correct package URI resolution
jcollins-g Feb 10, 2021
8529149
dartfmt
jcollins-g Feb 10, 2021
9eed293
dartfmt / delete TODO
jcollins-g Feb 10, 2021
e47e18e
Add dependency overrides to test package changes across repository
jcollins-g Feb 10, 2021
5067ec5
Review comments, changelog, package versioning, dependency nightmare …
jcollins-g Feb 10, 2021
7e3d938
Update SDK constraints to disallow 2.9, 2.10 where needed and adjust …
jcollins-g Feb 10, 2021
93d5ae7
Forgot that _test_null_safety actually is null safe.
jcollins-g Feb 10, 2021
28fdc23
Adjust sdk constraint to effectively, 2.12 without null safety
jcollins-g Feb 11, 2021
148a629
Change from dev to beta to avoid 2.13 for now
jcollins-g Feb 11, 2021
c3aae4f
Merge branch 'master' into glob200
jcollins-g Feb 11, 2021
d9e14e2
Add skip and build_config sdk constraint revert
jcollins-g Feb 12, 2021
752f790
initial changes
jcollins-g Feb 12, 2021
0ad99d5
Tweak changelogs and pubspec quotation
jcollins-g Feb 12, 2021
794b6f9
Merge branch 'glob200' into glob200+analyzer
jcollins-g Feb 12, 2021
89d838b
Update pubspecs for analyzer
jcollins-g Feb 12, 2021
4b5edfa
Merge branch 'master' into glob200
jcollins-g Feb 12, 2021
7e23a6d
Merge branch 'glob200' into glob200+analyzer
jcollins-g Feb 12, 2021
67e7e40
cleanup
jcollins-g Feb 12, 2021
28a16ab
cleanup 2
jcollins-g Feb 12, 2021
cf83c34
Merge branch 'master' into glob200+analyzer
jcollins-g Feb 16, 2021
80273dc
fix built_value_generator and deprecations
jcollins-g Feb 16, 2021
44b575c
actually commit dartfmt fix
jcollins-g Feb 16, 2021
390b5e2
Try adding scratch_space to integration test deps
jcollins-g Feb 16, 2021
497ffc1
Review comment
jcollins-g Feb 16, 2021
b6f03b0
override build_config temporarily
jcollins-g Feb 16, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
456 changes: 198 additions & 258 deletions .github/workflows/dart.yml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion _test/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

os:
- linux
Expand Down
2 changes: 1 addition & 1 deletion _test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ environment:
sdk: ">=2.3.0 <3.0.0"

dev_dependencies:
analyzer: ^0.41.0
analyzer: ^1.0.0
path: ^1.4.2
test: ^1.6.2
test_process: ^1.0.4
Expand Down
2 changes: 1 addition & 1 deletion _test_common/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
2 changes: 1 addition & 1 deletion _test_null_safety/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

os:
- linux
Expand Down
2 changes: 1 addition & 1 deletion _test_null_safety/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ environment:

dev_dependencies:
js: ^0.6.3
test: ^1.16.0-nullsafety
test: ^1.16.0

dependency_overrides:
build:
Expand Down
3 changes: 2 additions & 1 deletion build/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 1.6.3
## 1.6.3-dev

- Use latest analyzer version `1.x`.
- Use latest glob version `2.x`.

## 1.6.2
Expand Down
2 changes: 1 addition & 1 deletion build/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
2 changes: 1 addition & 1 deletion build/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment:
sdk: ">=2.11.99 <3.0.0"

dependencies:
analyzer: '>=0.35.0 <0.42.0'
analyzer: ^1.0.0
async: ">=1.13.3 <3.0.0"
convert: ">=2.0.0 <4.0.0"
crypto: ">=0.9.2 <4.0.0"
Expand Down
5 changes: 5 additions & 0 deletions build_config/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.4.6-dev

- Comment out dev dependency temporarily to break source_gen/json_serializable
dependency loop.

## 0.4.5

- Allow `package:json_annotation` `v4.x`.
Expand Down
22 changes: 5 additions & 17 deletions build_config/lib/src/builder_definition.dart
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,16 @@ class BuilderDefinition {
String get key => builderKeyExpando[this];

/// The names of the top-level methods in [import] from args -> Builder.
@JsonKey(
name: 'builder_factories',
nullable: false,
required: true,
disallowNullValue: true)
@JsonKey(name: 'builder_factories', required: true, disallowNullValue: true)
final List<String> builderFactories;

/// The import to be used to load `clazz`.
@JsonKey(nullable: false, required: true, disallowNullValue: true)
@JsonKey(required: true, disallowNullValue: true)
final String import;

/// A map from input extension to the output extensions created for matching
/// inputs.
@JsonKey(
name: 'build_extensions',
nullable: false,
required: true,
disallowNullValue: true)
@JsonKey(name: 'build_extensions', required: true, disallowNullValue: true)
final Map<String, List<String>> buildExtensions;

/// The name of the dart_library target that contains `import`.
Expand Down Expand Up @@ -176,15 +168,11 @@ class PostProcessBuilderDefinition {

/// The name of the top-level method in [import] from
/// Map<String, dynamic> -> Builder.
@JsonKey(
name: 'builder_factory',
nullable: false,
required: true,
disallowNullValue: true)
@JsonKey(name: 'builder_factory', required: true, disallowNullValue: true)
final String builderFactory;

/// The import to be used to load `clazz`.
@JsonKey(nullable: false, required: true, disallowNullValue: true)
@JsonKey(required: true, disallowNullValue: true)
final String import;

/// A list of input extensions for this builder.
Expand Down
2 changes: 1 addition & 1 deletion build_config/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
5 changes: 3 additions & 2 deletions build_config/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_config
version: 0.4.5
version: 0.4.6-dev
description: Support for parsing `build.yaml` configuration.
repository: https://github.com/dart-lang/build/tree/master/build_config

Expand All @@ -16,7 +16,8 @@ dependencies:

dev_dependencies:
build_runner: ^1.0.0
json_serializable: ^3.0.0
# TODO: Untangle source_gen dependency
#json_serializable: ^3.0.0
term_glyph: ^1.0.0
test: ^1.6.0

Expand Down
2 changes: 1 addition & 1 deletion build_daemon/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
8 changes: 3 additions & 5 deletions build_daemon/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,19 @@ dependencies:

dev_dependencies:
build_runner: ^1.0.0
built_value_generator: ^7.0.0
# TODO: untangle analyzer dependency
#built_value_generator: ^7.0.0
mockito: ^4.0.0
test: ^1.3.3
test_descriptor: ^1.1.1
uuid: ^2.0.0

dependency_overrides:
## Remove these and replace with updated constraints once valid build-wide
analyzer: 1.0.0
uuid: 3.0.0-nullsafety.0
## Remove each of the following as they are published
build_config:
path: ../build_config
build_runner:
path: ../build_runner
build_runner_core:
path: ../build_runner_core
## Remove each of the above as they are published
## Remove each of the above as they are published
1 change: 1 addition & 0 deletions build_modules/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 3.0.5-dev

- Update to glob `2.x`.
- Update to analyzer `1.x`.

## 3.0.4

Expand Down
2 changes: 1 addition & 1 deletion build_modules/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
4 changes: 2 additions & 2 deletions build_modules/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment:
sdk: ">=2.11.99 <3.0.0"

dependencies:
analyzer: ">0.36.4 <0.42.0"
analyzer: ^1.0.0
async: ^2.0.0
bazel_worker: ">=0.1.20 <2.0.0"
build: ">=1.3.0 <2.0.0"
Expand Down Expand Up @@ -51,4 +51,4 @@ dependency_overrides:
path: ../build_test
scratch_space:
path: ../scratch_space
## Remove each of the above as they are published
## Remove each of the above as they are published
4 changes: 4 additions & 0 deletions build_resolvers/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.5.4-dev

- Allow analyzer 1.0.0.

## 1.5.3

- Allow the null safe pre-release of `package_config`.
Expand Down
2 changes: 1 addition & 1 deletion build_resolvers/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
8 changes: 4 additions & 4 deletions build_resolvers/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: build_resolvers
version: 1.5.3
version: 1.5.4-dev
description: Resolve Dart code in a Builder
homepage: https://github.com/dart-lang/build/tree/master/build_resolvers

environment:
sdk: ">=2.9.0 <3.0.0"
sdk: ">=2.11.99 <3.0.0"

dependencies:
analyzer: ">=0.40.1 <0.42.0"
analyzer: ^1.0.0
build: ">=1.6.0 <1.7.0"
crypto: ">=2.0.0 <4.0.0"
graphs: ^0.2.0
Expand All @@ -30,4 +30,4 @@ dependency_overrides:
path: ../build_config
build_test:
path: ../build_test
## Remove each of the above as they are published
## Remove each of the above as they are published
2 changes: 1 addition & 1 deletion build_runner/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
2 changes: 1 addition & 1 deletion build_runner/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@ dependency_overrides:
path: ../build_web_compilers
scratch_space:
path: ../scratch_space
## Remove each of the above as they are published
## Remove each of the above as they are published
3 changes: 2 additions & 1 deletion build_runner/test/generate/run_script_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,13 @@ main(List<String> args) async {
await d.dir('a', [
await pubspec('a', currentIsolateDependencies: [
'build',
'build_config', // TODO: remove after publishing
'build_daemon',
'build_resolvers',
'build_runner',
'build_runner_core',
'build_test',
'glob'
'glob',
]),
d.dir('bin', [
d.file('main.dart', executableFileContent),
Expand Down
2 changes: 1 addition & 1 deletion build_runner_core/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
1 change: 1 addition & 0 deletions build_test/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 1.3.7-dev

- Update to analyzer `1.x`.
- Update to glob `2.x`.

## 1.3.6
Expand Down
2 changes: 1 addition & 1 deletion build_test/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
4 changes: 2 additions & 2 deletions build_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies:
watcher: '>=0.9.7 <2.0.0'

dev_dependencies:
analyzer: ">=0.35.4 <0.42.0"
analyzer: ^1.0.0
collection: ^1.14.0

dependency_overrides:
Expand All @@ -36,4 +36,4 @@ dependency_overrides:
path: ../build_config
build_resolvers:
path: ../build_resolvers
## Remove each of the above as they are published
## Remove each of the above as they are published
4 changes: 4 additions & 0 deletions build_vm_compilers/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.7-dev

- Update to latest analyzer version `1.0.0`.

## 1.0.6

- Allow the latest analyzer verion `0.41.x`.
Expand Down
2 changes: 1 addition & 1 deletion build_vm_compilers/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
8 changes: 4 additions & 4 deletions build_vm_compilers/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: build_vm_compilers
version: 1.0.6
version: 1.0.7-dev
description: Builder implementations wrapping Dart VM compilers.
homepage: https://github.com/dart-lang/build/tree/master/build_vm_compilers

environment:
sdk: ">=2.9.0 <3.0.0"
sdk: ">=2.11.99 <3.0.0"

dependencies:
analyzer: ">=0.36.4 <0.42.0"
analyzer: ^1.0.0
build: ^1.0.0
build_config: ">=0.3.0 <0.5.0"
build_modules: ^2.0.0
Expand Down Expand Up @@ -41,4 +41,4 @@ dependency_overrides:
path: ../build_test
scratch_space:
path: ../scratch_space
## Remove each of the above as they are published
## Remove each of the above as they are published
1 change: 1 addition & 0 deletions build_vm_compilers/test/vm_kernel_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ void main() {
'build_runner',
'build_runner_core',
'build_vm_compilers',
'scratch_space',
], versionDependencies: {
'glob': 'any',
'path': 'any',
Expand Down
3 changes: 2 additions & 1 deletion build_web_compilers/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 2.16.4
## 2.16.4-dev

- Update analyzer to `1.x`.
- Update glob to `2.x`.

## 2.16.3
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment:
sdk: ">=2.11.99 <3.0.0"

dependencies:
analyzer: ">=0.36.4 <0.42.0"
analyzer: ^1.0.0
archive: '>=2.0.0 <4.0.0'
bazel_worker: ">=0.1.18 <2.0.0"
build: ">=1.5.0 <2.0.0"
Expand Down
2 changes: 1 addition & 1 deletion example/lib/example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Visible libraries: $visibleLibraries

Iterable<Element> allElements(LibraryElement element) sync* {
for (var cu in element.units) {
yield* cu.functionTypeAliases;
yield* cu.typeAliases;
yield* cu.functions;
yield* cu.mixins;
yield* cu.topLevelVariables;
Expand Down
2 changes: 1 addition & 1 deletion example/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dart:
- beta
- dev

stages:
- analyze_and_format:
Expand Down
Loading