Skip to content

Use HttpMultiServer loopback #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2019
Merged

Use HttpMultiServer loopback #2265

merged 2 commits into from
May 10, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented May 10, 2019

This should close dart-lang/webdev#375

@grouma grouma requested a review from jakemac53 May 10, 2019 18:05
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label May 10, 2019
@grouma grouma changed the title Multi server fix Use HttpMultiServer loopback May 10, 2019
@grouma grouma changed the base branch from build_daemon-0.6.1 to master May 10, 2019 18:08
@grouma grouma changed the base branch from master to build_daemon-0.6.1 May 10, 2019 18:08
@grouma
Copy link
Member Author

grouma commented May 10, 2019

Ran the tests locally:

➜  build git:(multi-server-fix) mono_repo presubmit
_test
  SDK: dev TASK: dartanalyzer --fatal-infos --fatal-warnings .
    success
  SDK: dev TASK: pub run build_runner test -- -p chrome
    success
  SDK: dev TASK: pub run build_runner test -- -p vm test/configurable_uri_test.dart
    success
  SDK: dev TASK: pub run test --total-shards 6 --shard-index 0
    success
  SDK: dev TASK: pub run test --total-shards 6 --shard-index 1
    success
  SDK: dev TASK: pub run test --total-shards 6 --shard-index 2
    success
  SDK: dev TASK: pub run test --total-shards 6 --shard-index 3
    success
  SDK: dev TASK: pub run test --total-shards 6 --shard-index 4
    success
  SDK: dev TASK: pub run test --total-shards 6 --shard-index 5
    success

@grouma grouma merged commit 9328893 into build_daemon-0.6.1 May 10, 2019
@grouma grouma deleted the multi-server-fix branch May 10, 2019 19:55
grouma added a commit that referenced this pull request May 21, 2019
@grouma
Use HttpMultiServer loopback (#2265) (#2267)
10de1d5 
This should close dart-lang/webdev#375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grouma @jakemac53 @natebosch @googlebot