Add enum support to Schema
#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
jakemac53
reviewed
Jun 25, 2025
pkgs/dart_mcp/lib/src/api/tools.dart
Outdated
| String? get description => _value['description'] as String?; | ||
|
|
||
| /// The allowed enum values. | ||
| Set<String> get values => (_value['enum'] as Set).cast<String>(); |
There was a problem hiding this comment.
Should we handle null values better here similar to the previous PR?
There was a problem hiding this comment.
Yes, we should.
pkgs/dart_mcp/lib/src/api/tools.dart
Outdated
| String? get description => _value['description'] as String?; | ||
|
|
||
| /// The allowed enum values. | ||
| Set<String> get values => (_value['enum'] as Set).cast<String>(); |
There was a problem hiding this comment.
This is typically going to be a List, not a Set. We could call toSet, but I would probably just make it have an Iterable type so that it can be either? We should also validate that the JSON encoder can handle any kind of Iterable.
There was a problem hiding this comment.
Yeah, I went back and forth on that too. Okay, I'll just make it an Iterable.
There was a problem hiding this comment.
I left out the .toSet, but I did add an assert to check for duplicate entries, which is why I wanted to use .toSet in the first place.
jakemac53
reviewed
Jun 25, 2025
jakemac53
approved these changes
Jun 25, 2025
jakemac53
reviewed
Jun 25, 2025
jakemac53
requested changes
Jun 25, 2025
jakemac53
approved these changes
Jun 25, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 26, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/706d224..d0b89cf): d0b89cf 2025-06-25 Greg Spencer Add enum support to `Schema` (dart-lang/ai#190) f219861 2025-06-26 Brett Morgan Update `simple_server.dart` (dart-lang/ai#187) 8e3365f 2025-06-24 Greg Spencer Add error checks for accessing Request members (dart-lang/ai#184) protobuf (https://github.com/dart-lang/protobuf/compare/0bfff0c..bce362d): bce362d 2025-06-24 Devon Carew prep to publish 22.4.0 (google/protobuf.dart#1023) 269e004 2025-06-24 Devon Carew improve the readability of generated gRPC client files (google/protobuf.dart#1021) 48ba649 2025-06-24 Devon Carew update the header for generated files (google/protobuf.dart#1022) webdev (https://github.com/dart-lang/webdev/compare/6dc3dde..7f376d2): 7f376d24 2025-06-25 Derek Xu Set package versions to WIP versions (dart-lang/webdev#2637) Change-Id: Ib720f5127f3fddeb82b62cf13f24c3ddb4038e33 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/437260 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for adding Elicitation support, this add
enumsupport to the Schema class.Elicitations can request enum responses as part of their
requestedSchema.Tests