-
Notifications
You must be signed in to change notification settings - Fork 21
add homepage, repository, and documentation links to the pub result #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @csells |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
One open question, should we default the documentation link to Also, should we link to the actual pub page? That would show the readme content at least |
I think yes. The latest one is most likely the one most in use (especially for the majority of packages which haven't released in a while).
Maybe linking to the README itself might be more helpful? It'll be in Markdown, which the LLM would grok better anyhow, and because it's called "README" might be more attractive to the LLM to actually fetch and read. |
I am not sure we can reliably link to the README is the issue. We could potentially do that if the repo/homepage are GitHub links, as we know the rough structure of GitHub. |
Separate but related question, should we just always include this, separate from the |
In that case, I think the pub page is probably the next best thing. |
Would |
That won't always work for all packages because it assumes they have a file at |
Although, we actually do have the information to know all the public libraries, so we could link to each of their documentation pages. |
Ok @gspencergoog I added docs links for all the libraries now :) |
Another idea here is the keys in the |
cc @sigurdm do you know if the library names correspond to import paths (can we do Update: Looks like it won't work out of the box today, https://pub.dev/documentation/test/latest/bootstrap_browser/ is an example, we just get the name {
"name": "browser",
"qualifiedName": "browser",
"href": "bootstrap_browser/",
"kind": 9,
"packageRank": 0,
"desc": ""
}, We also can't get away with mangling the href (replace underscores with |
Nice! |
The pub.dev site must have a way to figure out all of the library links: it displays them. Can we ask them to add that info to the API? |
That is why I have cc'd @sigurdm on here :). It might be harder than you would think, those pages are dartdoc output which afaik you cannot get in a structured form. Clearly pub is already doing something here though to extract all the symbols in a package so hopefully it is possible to also provide the library imports. |
I am going to go ahead and merge this as is but @sigurdm if you have thoughts please comment and I can follow up |
Oh actually, I need approval from @gspencergoog first :) |
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/1d9d60c..f2b48c6): f2b48c6 2025-06-09 Nate Bosch Retain compatibility with 3.7 SDKs (dart-lang/ai#163) 52adf08 2025-06-06 Jacob MacDonald add homepage, repository, and documentation links to the pub result (dart-lang/ai#155) fa1c2be 2025-06-06 Nate Bosch Always use the failures-only reporter for testing (dart-lang/ai#160) 66a152f 2025-06-06 Nate Bosch Instruct clients to prefer MCP (dart-lang/ai#161) 55ad850 2025-06-05 Jacob MacDonald Add a retroactive changelog (dart-lang/ai#157) b08a610 2025-06-05 Jacob MacDonald Update instructions, add cursor install link (dart-lang/ai#159) web (https://github.com/dart-lang/web/compare/f1becf0..de6b3e4): de6b3e4 2025-06-06 Srujan Gaddam Add missing copyrights and delete empty files (dart-lang/web#371) 74a33ba 2025-06-06 Kevin Moore Add in a missing library directive, missing new line (dart-lang/web#370) 4d24eb5 2025-06-06 nikeokoronkwo [web_generator] Setting up `web_generator` for Dart JS Interop Gen (dart-lang/web#368) webdev (https://github.com/dart-lang/webdev/compare/55941b0..661dafd): 661dafd4 2025-06-08 Srujan Gaddam Defer execution of main until resume for hot restart with DDC library bundle format (dart-lang/webdev#2623) 01a3b9d7 2025-06-06 Nicholas Shahan Remove skip from chrome proxy service test Change-Id: If3d4326d0bacf47a4d95520dbd0aac5fb58de439 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433363 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #154
This won't automatically include examples, as that would be a fair bit more involved, but it will include the documentation link if provided by the package.