fix(dart_frog): revert Expando perf optimization
#1908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
requested review from
alestiago,
erickzanardo,
marcossevilla and
renancaraujo
as code owners
felangel
added
the
product: dart frog
felangel
changed the title
Expando perf optimization
marcossevilla
approved these changes
Nov 3, 2025
erickzanardo
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Request.read#1410 because the use of expando introduced a regression where multiple request body reads across middleware:handler gaps would previously work and no longer work after this change (due to the fact that the internal request was modified).Type of Change