Skip to content

feat(dart_frog): add defaultDocument to createStaticFileHandler #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 30, 2025
Merged

feat(dart_frog): add defaultDocument to createStaticFileHandler #1901

merged 5 commits into from
Oct 30, 2025
+60 −2

Conversation

@mtwichel
Copy link
Contributor

@mtwichel mtwichel commented Oct 29, 2025 •
edited by felangel
Loading

Status

READY

Description

Adds the defaultDocument parameter to the createStaticFileHandler function which allows developers to specify a file to return at the root of a handler.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel changed the title feat: add default document on static file handlers feat(dart_frog): add defaultDocument to createStaticFileHandler Oct 30, 2025
felangel
felangel reviewed Oct 30, 2025
View reviewed changes
felangel
felangel approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@felangel
Copy link
Contributor

I think this doesn't technically solve #445 since that involves automatically serving an index.html if one exists. We can try to address that in a separate PR

@felangel felangel merged commit fb66298 into dart-frog-dev:main Oct 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felangel felangel felangel approved these changes

@alestiago alestiago Awaiting requested review from alestiago alestiago is a code owner

@erickzanardo erickzanardo Awaiting requested review from erickzanardo erickzanardo is a code owner

@marcossevilla marcossevilla Awaiting requested review from marcossevilla marcossevilla is a code owner

@renancaraujo renancaraujo Awaiting requested review from renancaraujo renancaraujo is a code owner

@wolfenrain wolfenrain Awaiting requested review from wolfenrain wolfenrain is a code owner

Assignees

@mtwichel mtwichel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Serve public/index.html from root handler

2 participants

@mtwichel @felangel