Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add prefer-enums-by-name rule #919

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Conversation

incendial
Copy link
Member

@incendial incendial commented Jul 12, 2022

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Implements https://github.com/dart-lang/linter/issues/3481

@incendial incendial self-assigned this Jul 12, 2022
@incendial incendial added type: enhancement New feature or request area-rules labels Jul 12, 2022
@incendial incendial added this to the 4.17.0 milestone Jul 12, 2022
@github-actions
Copy link

github-actions bot commented Jul 12, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 454

  • Total lines of source code: 7961

  • Total classes: 314

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1350.0 hours

  • Found issues: 6 ⚠

@incendial incendial requested a review from dkrutskikh July 13, 2022 10:51
@incendial incendial marked this pull request as ready for review July 13, 2022 10:51
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #919 (6280f6d) into master (64d39b4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     dart-lang/linter#919      +/-   ##
==========================================
+ Coverage   87.33%   87.37%   +0.04%     
==========================================
  Files         300      302       +2     
  Lines        6205     6228      +23     
==========================================
+ Hits         5419     5442      +23     
  Misses        786      786              
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 71.42% <ø> (ø)
...refer_enums_by_name/prefer_enums_by_name_rule.dart 100.00% <100.00%> (ø)
...rules/rules_list/prefer_enums_by_name/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d39b4...6280f6d. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dkrutskikh dkrutskikh merged commit b6a3946 into master Jul 15, 2022
@dkrutskikh dkrutskikh deleted the prefer-enums-by-name branch July 15, 2022 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants