Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: improve avoid-returning-widgets builder functions handling #693

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[X] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

@incendial incendial added type: enhancement New feature or request area-rules labels Feb 13, 2022
@incendial incendial added this to the 4.11.0 milestone Feb 13, 2022
@incendial incendial requested a review from dkrutskikh February 13, 2022 10:24
@incendial incendial self-assigned this Feb 13, 2022
@github-actions
Copy link

github-actions bot commented Feb 13, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Feb 13, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 390

  • Total lines of source code: 6939

  • Total classes: 259

  • Average Cyclomatic Number per line of code: 0.35 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1126.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #693 (078bf57) into master (33d3184) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   86.43%   86.45%   +0.01%     
==========================================
  Files         255      255              
  Lines        5456     5464       +8     
==========================================
+ Hits         4716     4724       +8     
  Misses        740      740              
Impacted Files Coverage Δ
...eturning_widgets/avoid_returning_widgets_rule.dart 100.00% <ø> (ø)
...es/rules_list/avoid_returning_widgets/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d3184...078bf57. Read the comment docs.

@dkrutskikh dkrutskikh merged commit c38691a into master Feb 13, 2022
@dkrutskikh dkrutskikh deleted the avoid-returning-widget-block-body branch February 13, 2022 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants