fix: correctly handle implicit type parameters for no-equal-arguments

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+* fix: correctly handle implicit type parameters for [`no-equal-arguments`](https://dcm.dev/docs/individuals/rules/common/no-equal-arguments).
 * fix: correctly handle `dynamic` type for [`avoid-passing-async-when-sync-expected`](https://dcm.dev/docs/individuals/rules/common/avoid-passing-async-when-sync-expected).
 * fix: check `didChangeDependencies` for [`avoid-unnecessary-setstate`](https://dcm.dev/docs/individuals/rules/flutter/avoid-unnecessary-setstate).
 * fix: add new config option for [`no-equal-arguments`](https://dcm.dev/docs/individuals/rules/common/no-equal-arguments).

lib/src/analyzers/lint_analyzer/rules/rules_list/no_equal_arguments/visitor.dart

@@ -40,14 +40,16 @@ class _Visitor extends RecursiveAstVisitor<void> {
             arg is NamedExpression &&
             argument.expression is! Literal &&
             arg.expression is! Literal) {
-          return argument.expression.toString() == arg.expression.toString();
+          return haveSameParameterType(argument.expression, arg.expression) &&
+              argument.expression.toString() == arg.expression.toString();
         }
 
         if (_bothLiterals(argument, arg)) {
           return argument == arg;
         }
 
-        return argument.toString() == arg.toString();
+        return haveSameParameterType(argument, arg) &&
+            argument.toString() == arg.toString();
       });
 
       if (argument != lastAppearance) {

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/visitor.dart

@@ -201,6 +201,5 @@ class _BlockVisitor extends RecursiveAstVisitor<void> {
   bool _haveDifferentParameterTypes(AstNode visitedInvocation, AstNode node) =>
       visitedInvocation is Expression &&
       node is Expression &&
-      visitedInvocation.staticParameterElement?.type !=
-          node.staticParameterElement?.type;
+      !haveSameParameterType(visitedInvocation, node);
 }

lib/src/utils/node_utils.dart

@@ -43,6 +43,9 @@ bool isOverride(List<Annotation> metadata) => metadata.any(
           node.name.name == 'override' && node.atSign.type == TokenType.AT,
     );
 
+bool haveSameParameterType(Expression left, Expression right) =>
+    left.staticParameterElement?.type == right.staticParameterElement?.type;
+
 bool isEntrypoint(String name, NodeList<Annotation> metadata) =>
     name == 'main' ||
     _hasPragmaAnnotation(metadata) ||

test/src/analyzers/lint_analyzer/rules/rules_list/no_equal_arguments/examples/provider_example.dart

@@ -0,0 +1,55 @@
+class MyApp extends StatefulWidget {
+  const MyApp();
+}
+
+class _MyAppState extends State<MyApp> {
+  @override
+  void initState() {
+    super.initState();
+
+    final model = MyModel(
+      context.read(),
+      context.read(),
+      context.read(),
+    );
+  }
+
+  @override
+  Widget build(BuildContext context) {
+    return Container();
+  }
+}
+
+class A {}
+
+class B {}
+
+class C {}
+
+class MyModel {
+  final A a;
+  final B b;
+  final C c;
+
+  const MyModel(this.a, this.b, this.c);
+}
+
+class Widget {}
+
+class StatefulWidget extends Widget {}
+
+class BuildContext {}
+
+extension ReadContext on BuildContext {
+  T read<T>() {
+    return 'value' as T;
+  }
+}
+
+abstract class State<T> {
+  void initState();
+
+  void setState(VoidCallback callback) => callback();
+
+  BuildContext get context => BuildContext();
+}

test/src/analyzers/lint_analyzer/rules/rules_list/no_equal_arguments/no_equal_arguments_rule_test.dart

@@ -9,6 +9,8 @@ const _incorrectExamplePath =
     'no_equal_arguments/examples/incorrect_example.dart';
 const _namedParametersExamplePath =
     'no_equal_arguments/examples/named_parameters_example.dart';
+const _providerExamplePath =
+    'no_equal_arguments/examples/provider_example.dart';
 
 void main() {
   group('NoEqualArgumentsRule', () {
@@ -58,34 +60,41 @@ void main() {
 
       RuleTestHelper.verifyNoIssues(issues);
     });
-  });
 
-  test('reports about found issue with default config', () async {
-    final unit =
-        await RuleTestHelper.resolveFromFile(_namedParametersExamplePath);
-    final issues = NoEqualArgumentsRule().check(unit);
+    test('reports about found issue with default config', () async {
+      final unit =
+          await RuleTestHelper.resolveFromFile(_namedParametersExamplePath);
+      final issues = NoEqualArgumentsRule().check(unit);
 
-    RuleTestHelper.verifyIssues(
-      issues: issues,
-      startLines: [9],
-      startColumns: [3],
-      locationTexts: ['lastName: firstName'],
-      messages: ['The argument has already been passed.'],
-    );
-  });
+      RuleTestHelper.verifyIssues(
+        issues: issues,
+        startLines: [9],
+        startColumns: [3],
+        locationTexts: ['lastName: firstName'],
+        messages: ['The argument has already been passed.'],
+      );
+    });
 
-  test('reports no issues with custom config', () async {
-    final unit =
-        await RuleTestHelper.resolveFromFile(_namedParametersExamplePath);
-    final config = {
-      'ignored-parameters': [
-        'lastName',
-      ],
-    };
+    test('reports no issues for provider read', () async {
+      final unit = await RuleTestHelper.resolveFromFile(_providerExamplePath);
+      final issues = NoEqualArgumentsRule().check(unit);
 
-    final issues = NoEqualArgumentsRule(config).check(unit);
+      RuleTestHelper.verifyNoIssues(issues);
+    });
 
-    RuleTestHelper.verifyNoIssues(issues);
+    test('reports no issues with custom config', () async {
+      final unit =
+          await RuleTestHelper.resolveFromFile(_namedParametersExamplePath);
+      final config = {
+        'ignored-parameters': [
+          'lastName',
+        ],
+      };
+
+      final issues = NoEqualArgumentsRule(config).check(unit);
+
+      RuleTestHelper.verifyNoIssues(issues);
+    });
   });
 
   test('reports about found issue with ignored arguments config', () async {