Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: correctly handle FunctionExpressions for avoid-redundant-async #1124

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added this to the 5.4.0 milestone Dec 26, 2022
@incendial incendial requested a review from dkrutskikh December 26, 2022 11:38
@incendial incendial self-assigned this Dec 26, 2022
@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 548

  • Total lines of source code: 9760

  • Total classes: 419

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 2072.0 hours

  • Found issues: 5 ⚠

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #1124 (eca690e) into master (a352607) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   85.19%   85.20%           
=======================================
  Files         342      342           
  Lines        7540     7541    +1     
=======================================
+ Hits         6424     6425    +1     
  Misses       1116     1116           
Impacted Files Coverage Δ
...id_redundant_async/avoid_redundant_async_rule.dart 100.00% <100.00%> (ø)
...ules/rules_list/avoid_redundant_async/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 8af25bd into master Dec 28, 2022
@incendial incendial deleted the support-function-expressions branch December 28, 2022 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant