Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: support ignoring regular comments for format-comment #1110

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

#1106

@incendial incendial added type: enhancement New feature or request area-rules labels Dec 16, 2022
@incendial incendial added this to the 5.3.0 milestone Dec 16, 2022
@incendial incendial requested a review from dkrutskikh December 16, 2022 13:28
@incendial incendial self-assigned this Dec 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 537

  • Total lines of source code: 9472

  • Total classes: 404

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1992.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1110 (c18b4a1) into master (b8f190c) will increase coverage by 0.00%.
The diff coverage is 92.30%.

❗ Current head c18b4a1 differs from pull request most recent head e08b91e. Consider uploading reports for the commit e08b91e to get more accurate results

@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files         339      339           
  Lines        7445     7452    +7     
=======================================
+ Hits         6330     6336    +6     
- Misses       1115     1116    +1     
Impacted Files Coverage Δ
...rules_list/format_comment/format_comment_rule.dart 79.06% <85.71%> (+0.12%) ⬆️
...rules/rules_list/format_comment/config_parser.dart 100.00% <100.00%> (ø)
...lyzer/rules/rules_list/format_comment/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 8ec23cb into master Dec 16, 2022
@incendial incendial deleted the configuration-for-format-comment branch December 16, 2022 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant