Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: remove recursive traversal for ban-name #1090

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

#1087

@incendial incendial added this to the 5.2.0 milestone Dec 5, 2022
@incendial incendial requested a review from dkrutskikh December 5, 2022 07:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 526

  • Total lines of source code: 9339

  • Total classes: 397

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1920.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1090 (81b7380) into master (c4a9ad3) will increase coverage by 0.01%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
+ Coverage   84.89%   84.91%   +0.01%     
==========================================
  Files         333      333              
  Lines        7331     7332       +1     
==========================================
+ Hits         6224     6226       +2     
+ Misses       1107     1106       -1     
Impacted Files Coverage Δ
...nt_analyzer/rules/rules_list/ban_name/visitor.dart 81.25% <85.00%> (-0.81%) ⬇️
...lyzer/rules/rules_list/ban_name/ban_name_rule.dart 88.46% <100.00%> (+5.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 54d50d5 into master Dec 5, 2022
@incendial incendial deleted the revert-ban-name-recursive-traversal branch December 5, 2022 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant