[Rule change] ignore method invocations in a variable declaration for `prefer-moving-to-variable`

[w3ggy]

First of all. Thanks for amazing tool! We use flutter_hooks package on our project. When we add the prefer-moving-to-variable rule we see a lot of false-positive warnings related to hooks.

What rule do you want to change?
prefer-moving-to-variable

How will the change be implemented? (New option, new default behavior, etc.)?
Honestly, I don't know. It looks like we should use naming for omitting some function calls.

Please provide some example code that this change will affect:

    final key1 = useMemoized(() => GlobalKey<InputFieldState>(), []);
    final key2 = useMemoized(() => GlobalKey<InputFieldState>(), []);
    final key3 = useMemoized(() => GlobalKey<InputFieldState>(), []);
    final key4 = useMemoized(() => GlobalKey<InputFieldState>(), []);
    final key5 = useMemoized(() => GlobalKey<InputFieldState>(), []);

What does the rule currently do for this code?

Warns Prefer moving repeated invocations to variable and use it instead. (Documentation)

What will the rule do after it's changed?

It should skip hook validations

Are you willing to submit a pull request to implement this change?

I don't know how.

[incendial]

@w3ggy can you provide a repro? To understand the context in which keys are used.

[w3ggy]

@incendial complete pseudo-sample of the form. I removed all unnecessary logic to make it simple. Let me know if you need something else.

class CreateNewAccountPage extends HookWidget {
  const CreateNewAccountPage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    final focusNodeEmail = useFocusNode();
    final focusNodeUsername = useFocusNode();
    final focusNodeFirstName = useFocusNode();
    final focusNodeLastName = useFocusNode();
    final focusNodeDayOfBirth = useFocusNode();
    final focusNodeMobileNumber = useFocusNode();

    final textControllerEmail = useTextEditingController();
    final textControllerUserName = useTextEditingController();
    final textControllerFirstName = useTextEditingController();
    final textControllerLastName = useTextEditingController();
    final textControllerDayOfBirth = useTextEditingController();
    final textControllerMobileNumber = useTextEditingController();

    return Scaffold(
      backgroundColor: Colors.white,
      body: ListView(
        padding: const EdgeInsets.symmetric(horizontal: 24),
        children: [
          TextFormField(
            controller: textControllerEmail,
            focusNode: focusNodeEmail,
          ),
          TextFormField(
            controller: textControllerUserName,
            focusNode: focusNodeUsername,
          ),
          TextFormField(
            controller: textControllerFirstName,
            focusNode: focusNodeFirstName,
          ),
          TextFormField(
            controller: textControllerLastName,
            focusNode: focusNodeLastName,
          ),
          TextFormField(
            controller: textControllerDayOfBirth,
            focusNode: focusNodeDayOfBirth,
          ),
          TextFormField(
            controller: textControllerMobileNumber,
            focusNode: focusNodeMobileNumber,
          ),
        ],
      ),
    );
  }
}

And it seems strange that the linter highlights only the useFocusNode/useMemoized but not the useTextEditingController

I guess it is because the useFocusNode is just function invokation under the hood

and `useTextEditingController` is constructor invocation

[incendial]

and useTextEditingController is constructor invocation

Yes, you're right.

So, looks like the rule should ignore an invocation if it's already a part of the assignment.

[incendial]

And thank you for the details

[incendial]

Fixed in 5.5.0 🚀