Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

fix super.key false positive for use_key_in_widget_constructors #3295

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Mar 17, 2022

See: flutter/flutter#100297.

(Note that we don't have Flutter mocked for our rule tests so I resorted to "old-school" testing.)

/cc @bwilkerson

@coveralls
Copy link

coveralls commented Mar 17, 2022

Coverage Status

Coverage increased (+0.003%) to 95.691% when pulling 0702af6 on use_super_parameters_key_fp into 7f03036 on master.

Copy link
Contributor

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as-is, just one random thought.

@pq pq merged commit 6b4538c into master Mar 17, 2022
@pq pq deleted the use_super_parameters_key_fp branch March 17, 2022 17:23
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
…rt-archive/linter#3295)

* fix super.key false positive for `use_key_in_widget_constructors`

* - type test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants