Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

super_parameter support for type_init_formals #3165

Merged
merged 7 commits into from
Jan 20, 2022
Merged

super_parameter support for type_init_formals #3165

merged 7 commits into from
Jan 20, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Jan 19, 2022 •
edited
Loading

@devoncarew devoncarew mentioned this pull request Jan 19, 2022
Closed
14 tasks
@coveralls
Copy link

coveralls commented Jan 19, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 94.178% when pulling 2c2d397 on type_init_formals_super into 29b2651 on master.

@pq pq marked this pull request as draft January 19, 2022 23:54
@pq pq marked this pull request as ready for review January 20, 2022 00:13
scheglov
scheglov reviewed Jan 20, 2022
View reviewed changes
pq
pq commented Jan 20, 2022
View reviewed changes
Copy link
Contributor Author

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

scheglov
scheglov approved these changes Jan 20, 2022
View reviewed changes
@pq pq merged commit 5acea57 into master Jan 20, 2022
@pq pq deleted the type_init_formals_super branch January 20, 2022 00:55
bwilkerson
bwilkerson reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation needs to be updated. I haven't been remembering to check that in other PRs, so you should go through the ones you've already landed and double check them.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
super_parameter support for type_init_formals (dart-archive/linter#…
6d32858 
…3165)

* super_parameter support for `type_init_formals`

* unused import

* whoops

* sort

* whoops

* fixes

* formatting tweaks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson left review comments

@scheglov scheglov scheglov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pq @coveralls @scheglov @bwilkerson