This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Fix infinite loop with bad button close tag #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #122 Add 'button' to the tags that are processed with `endTagBlock`. The spec at https://html.spec.whatwg.org/multipage/parsing.html includes 'button' in the list of end tags with this treatement. Add a new `.dat` file for regression test. It include an `#info` field which is new but can be parsed safety to mark the issue for which it is a test. This test loops endlessly before the fix and passes after the fix. Note that since errors are currently untested and test fail if they are tested the error will be left without content for now.
|
|
|
Note that |
|
That's a far more elegant fix :) |
|
+1 |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
Closes dart-lang/html#122 Add 'button' to the tags that are processed with `endTagBlock`. The spec at https://html.spec.whatwg.org/multipage/parsing.html includes 'button' in the list of end tags with this treatment. Add a new `.dat` file for regression test. It include an `#info` field which is new but can be parsed safely to mark the issue for which it is a test. This test loops endlessly before the fix and passes after the fix. Note that since errors are currently untested and tests fail if they are tested the error will be left without content for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/tools#1036
Add 'button' to the tags that are processed with
endTagBlock. The specat https://html.spec.whatwg.org/multipage/parsing.html includes 'button'
in the list of end tags with this treatment.
Add a new
.datfile for regression test. It include an#infofieldwhich is new but can be parsed safely to mark the issue for which it is
a test. This test loops endlessly before the fix and passes after the
fix.
Note that since errors are currently untested and tests fail if they are
tested the error will be left without content for now.