This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Update code to use errno values #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all code that throws
FileSystemExceptionto properly setthe corresponding
osError.errorCode, which allows us to update thetests to expect the error code rather than the error message. This in turn
allows the tests to be more robust across locales and platforms.
To deal with the fact that different platforms have different errno values
(which will be exposed and tested via
LocalFileSystem), this changecreates an
ErrorCodesclass with static getters for the set of errnovalues that are common to all platforms. This code can be removed once
dart-lang/sdk#28860 is resolved and live.
Fixes dart-lang/tools#613