Skip to content
This repository was archived by the owner on Dec 6, 2017. It is now read-only.
This repository was archived by the owner on Dec 6, 2017. It is now read-only.

Comments to getByKey method #228

Open
@acherepanov

Description

@acherepanov

In this piece of code in lib/src/injector.dart do you mean An alternative could be to recurse only when parent is not a RootInjector instead of An alternative could be to recurse only when parent is not a ModuleInjector?

    Binding binding = _bindings[id];
    // When binding is null, recurse instead of iterate because it:
    // 1. tracks key history on the stack for error reporting
    // 2. allows different types of ancestor injectors with alternative implementations.
    // An alternative could be to recurse only when parent is not a ModuleInjector
    if (binding == null) return _instances[id] = parent.getByKey(key);

When parent is a RootInjector, getByKey immediately throws exception, but in ModuleInjector this method works fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions