Skip to content
This repository was archived by the owner on Jun 3, 2020. It is now read-only.

Typo in link to 'implementing a Hello World http server'. #110

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Typo in link to 'implementing a Hello World http server'. #110

merged 2 commits into from
Apr 24, 2018

Conversation

vprusso
Copy link
Contributor

@vprusso vprusso commented Apr 24, 2018

In dart_io_mini_samples/README.md the link directory to the example "Implementing a 'Hello world' HTTP server" was not listed properly. Specifically, the "h" and "w" in the word "helloworld" were lowercase, when they should have been uppercase. Fixing this prevent a 404 error from occurring when attempting to navigate to this example.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@kevmoo
Copy link
Contributor

kevmoo commented Apr 24, 2018

@kwalrath – do we have an official owner here?

@vprusso
Copy link
Contributor Author

vprusso commented Apr 24, 2018

Hey @kevmoo sorry about the trouble there. I committed this to a different machine and the user I had globally set was different than the one I used to fork. That's completely on me, sorry for the trouble there.

@kevmoo
Copy link
Contributor

kevmoo commented Apr 24, 2018

@vprusso – no trouble 😄

@kevmoo kevmoo merged commit 4cd9ebf into dart-archive:master Apr 24, 2018
@kwalrath
Copy link
Contributor

@kevmoo No, no official owner. This repo was originally the source of dartlang.org/docs/cookbook, which we removed recently (#687) because the code wasn't being updated or tested.

@kwalrath
Copy link
Contributor

The following pages still have references to this repo:

src/_data/samples.yaml also refers to it, but I believe that file isn't used right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants