This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Annotate the type of 'variables' in class All and class None #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that we do not run into dart-lang/sdk#32412
kevmoo
reviewed
Mar 6, 2018
lib/src/all.dart
Outdated
| @@ -6,7 +6,7 @@ import '../boolean_selector.dart'; | |||
|
|
|||
| /// A selector that matches all inputs. | |||
| class All implements BooleanSelector { | |||
| final variables = const []; | |||
| final List<String> variables = const []; | |||
There was a problem hiding this comment.
Could this go on the right -> <String>[]?
kevmoo
reviewed
Mar 6, 2018
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: boolean_selector | |||
| version: 1.0.3-dev | |||
| version: 1.0.4-dev | |||
There was a problem hiding this comment.
Don't think this is needed, since 1.0.3 has not been released
There was a problem hiding this comment.
Yeah, this should just be 1.0.3.
nex3
suggested changes
Mar 6, 2018
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 1.0.3 | |||
|
|
|||
| * Annotate the type of 'variables' in class All and class None. | |||
There was a problem hiding this comment.
I'd write "Work around a common front-end inference bug." The changelog is intended for downstream users, and as far as they're concerned the only change here is that this now works with the CFE.
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: boolean_selector | |||
| version: 1.0.3-dev | |||
| version: 1.0.4-dev | |||
There was a problem hiding this comment.
Yeah, this should just be 1.0.3.
|
Thanks |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 18, 2024
Annotate the type of All.variables and None.variables to work around dart-lang/sdkdart-lang/boolean_selector#32412.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate the type of 'variables' in class All and class None to ensure that we do not run into dart-lang/sdk#32412