This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Tighten type for argument to evaluate
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking a `dynamic` throws away the static help that a caller would get with an argument type. Since it is easy to refactor callers currently passing an `Iterable<String>` to tear off the `.contains` method we can take the Function type always. This also improves inference for argument types in places that are passing a function literal.
|
Filing for discussion. The only known usage is in We may also want to punt on this until we do the null safety migration since that will also end up requiring a breaking change version bump and we can roll this in with that to reduce churn. |
|
After discussion we're going to go forward with this since the impact is so minimal - only the test packages use this and we can easily update deps. |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 18, 2024
…r#22) Taking a `dynamic` throws away the static help that a caller would get with an argument type. Since it is easy to refactor callers currently passing an `Iterable<String>` to tear off the `.contains` method we can take the Function type always. This also improves inference for argument types in places that are passing a function literal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a
dynamicthrows away the static help that a caller would getwith an argument type. Since it is easy to refactor callers currently
passing an
Iterable<String>to tear off the.containsmethod we cantake the Function type always. This also improves inference for argument
types in places that are passing a function literal.