reenabled @typescript-eslint/no-unnecessary-type-assertion

darren109 · Jan 2, 2021 · e36bad2 · e36bad2
1 parent 154cc29
commit e36bad2
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 8 deletions.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -29,7 +29,6 @@ rules:
   '@typescript-eslint/no-magic-numbers': off
   '@typescript-eslint/member-delimiter-style': off
   '@typescript-eslint/promise-function-async': off
-  '@typescript-eslint/no-unnecessary-type-assertion': off
   '@typescript-eslint/require-array-sort-compare': off
   '@typescript-eslint/no-floating-promises': off
   '@typescript-eslint/prefer-readonly': off

diff --git a/terminus-serial/src/buttonProvider.ts b/terminus-serial/src/buttonProvider.ts
@@ -28,7 +28,7 @@ export class ButtonProvider extends ToolbarButtonProvider {
             weight: 5,
             title: 'Serial connections',
             touchBarNSImage: 'NSTouchBarOpenInBrowserTemplate',
-            click: async () => {
+            click: () => {
                 this.activate()
             },
         }]

diff --git a/terminus-ssh/src/buttonProvider.ts b/terminus-ssh/src/buttonProvider.ts
@@ -28,7 +28,7 @@ export class ButtonProvider extends ToolbarButtonProvider {
             weight: 5,
             title: 'SSH connections',
             touchBarNSImage: 'NSTouchBarOpenInBrowserTemplate',
-            click: async () => {
+            click: () => {
                 this.activate()
             },
         }]

diff --git a/terminus-ssh/src/components/sshSettingsTab.component.ts b/terminus-ssh/src/components/sshSettingsTab.component.ts
@@ -134,7 +134,7 @@ export class SSHSettingsTabComponent {
                     name: connection.group!,
                     connections: [],
                 }
-                this.childGroups.push(group!)
+                this.childGroups.push(group)
             }
             group.connections.push(connection)
         }

diff --git a/terminus-ssh/src/services/ssh.service.ts b/terminus-ssh/src/services/ssh.service.ts
@@ -98,7 +98,7 @@ export class SSHService {
                     }
                 }
 
-                const sshFormatKey = parsedKey!.toString('openssh')
+                const sshFormatKey = parsedKey.toString('openssh')
                 const temp = await openTemp()
                 fs.close(temp.fd)
                 await fs.writeFile(temp.path, sshFormatKey)
@@ -359,7 +359,7 @@ export class SSHService {
                     name: connection.group!,
                     connections: [],
                 }
-                groups.push(group!)
+                groups.push(group)
             }
             group.connections.push(connection)
         }

diff --git a/terminus-terminal/src/features/pathDrop.ts b/terminus-terminal/src/features/pathDrop.ts
@@ -10,7 +10,7 @@ export class PathDropDecorator extends TerminalDecorator {
             this.subscribeUntilDetached(terminal, terminal.frontend?.dragOver$.subscribe(event => {
                 event.preventDefault()
             }))
-            this.subscribeUntilDetached(terminal, terminal.frontend?.drop$.subscribe(event => {
+            this.subscribeUntilDetached(terminal, terminal.frontend?.drop$.subscribe((event: DragEvent) => {
                 for (const file of event.dataTransfer!.files as any) {
                     this.injectPath(terminal, file.path)
                 }

diff --git a/terminus-terminal/src/frontends/xtermFrontend.ts b/terminus-terminal/src/frontends/xtermFrontend.ts
@@ -298,7 +298,7 @@ export class XTermFrontend extends Frontend {
             html += this.getLineAsHTML(selection.startRow, selection.startColumn, selection.endColumn)
         } else {
             html += this.getLineAsHTML(selection.startRow, selection.startColumn, this.xterm.cols)
-            for (let y = selection.startRow! + 1; y < selection.endRow; y++) {
+            for (let y = selection.startRow + 1; y < selection.endRow; y++) {
                 html += this.getLineAsHTML(y, 0, this.xterm.cols)
             }
             html += this.getLineAsHTML(selection.endRow, 0, selection.endColumn)