Handling Single-Line Comments in Table DDL #1905
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In Oracle table DDL, when single-line comments (--) are used after columns, Ora2Pg places commas after the comments.
This causes syntax errors in the converted PostgreSQL DDL. This occurs when fetching from source db.
Example:
Oracle Input:
CREATE TABLE employees (
employee_id NUMBER PRIMARY KEY,
first_name VARCHAR2(50) -- fname
,
last_name VARCHAR2(50) -- lname
,
hire_date DATE
);
Incorrect Ora2Pg Output:
CREATE TABLE employees (
employee_id INTEGER PRIMARY KEY,
first_name VARCHAR(50) -- fname,
last_name VARCHAR(50) -- lname,
hire_date DATE
);
Solution:
Updated logic to detect single-line comments during DDL reconstruction. Ensured that commas are placed before comments or moved to the next line if needed. Prevented syntax issues in PostgreSQL due to misplaced commas.